MBS-13802: Always use "Created (in)" for characters #3403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reosarevok
added
QoL
We changed this for sidebar display for Created a while ago, but I missed the artist editor, and area should use Created in for consistency.
mwiencek
approved these changes
Dec 3, 2024
reosarevok
added a commit
that referenced
this pull request
Dec 18, 2024
* master: Update POT files using the production database Update stylistic to 2.12.0 Update eslint to 9.16.0 Update stylistic to 2.11.0 Update stylistic to 2.10.1 Update eslint to 9.15.0 Update to eslint 9.14.0 Update eslint-plugin-react to 7.37.2 Update to eslint 9.13.0 Update eslint-plugin-react-hooks to 5.0.0 List and disable TS @Stylistic rules List and disable @stylistic/indent-binary-ops Add new @stylistic/curly-newline rule Group all @Stylistic rules Update @stylistic/eslint to 2.9.0 Update rules as per eslint 9.12.0 Update to eslint 9.12.0 Update eslint-plugin-react to 7.37.1 Restore now working no-named-as-default rules Update eslint-plugin-import to 2.31.0 Update hermes-parser to 0.24.0 Update eslint to v8.57.1 Update eslint-plugin-react to 7.36.1 Update eslint-plugin-react to 7.35.2 Update hermes packages Update @babel packages Implement import/no-mutable-exports eslint rule Update eslint-plugin-import to 2.30.0 MBS-12792: Hide ratings by spammer users (#2786) Mitigate flakiness in MBS-2604 test Log error to sentry if dates are dropped MBS-9063: Add tests MBS-9063: Ignore dates in Perl layer when editing rel types without them MBS-9063: Ignore dates in rels editor for rel types without them MBS-13858: Make email Message-Id unique (#3427) MBS-13854: Reword release label edit failure message (#3425) MBS-13170: Handle Bluesky links (#3423) MBS-13795: Update 初音ミク Wiki database validation and cleanup MBS-13850: Accept and cleanup French Ticketmaster MBS-13850: Avoid breaking Peruvian Ticketmaster Don't load no-discid tracklists Use "tbl medium" class in more places MBS-12593: Convert cdtoc/attach_filter_release to React MBS-13795: rename sidebar to original Japanese MBS-13802: Always use "Created (in)" for characters (#3403) MBS-13837: Update JunoDownload favicon (#3419) MBS-13801: Remove limits on tag cloud subqueries (#3400) MBS-13825: Display primary alias for entities on edit display MBS-13780: Show primary alias for series MBS-13780: Show primary alias for release groups MBS-13780: Show primary aliases in merge queue MBS-13780: Show primary alias for releases MBS-13780: Show primary alias for recordings Load artist aliases for instrument artist tab MBS-13780: Show primary alias for places MBS-13780: Show primary alias for genres MBS-13780: Show primary alias for events Split load_aliases from load_related_info and use in more places Use existing $artist_model variable MBS-13780: Show primary alias for labels MBS-13780: Show primary alias for areas MBS-13780: Show primary alias for works MBS-13580: Show primary aliases on artist credits Do not load ACs in set_lengths_to_cdtoc Drop unneeded passedHover Don't try to load artist credits if not supported MBS-13818: Show primary aliases on related entities Add attribute current_language to Server and Context MBS-13571: Show primary aliases on subscription page MBS-13561: Show primary aliases on tag page Do not show primary aliases for instruments Extract alias properties to role Extract and generalize load_aliases
reosarevok
added a commit
that referenced
this pull request
Jan 13, 2025
* beta: Translated using Weblate (Swedish) Translated using Weblate (Swedish) Translated using Weblate (Swedish) Translated using Weblate (Albanian) Translated using Weblate (Albanian) Translated using Weblate (Finnish) Translated using Weblate (Finnish) Update translation files Update POT files using the production database MBS-13885: Use jaxsta.io instead of jaxsta.com (#3435) MBS-13883: Use quebecinfomusique.com instead of qim.com (#3436) MBS-13591: Show error when blocking Bandcamp user page (#3440) MBS-13888: Also convert relative wiki links to /doc (#3439) Translated using Weblate (Chinese (Simplified Han script)) Translated using Weblate (Turkish) Translated using Weblate (German) Translated using Weblate (Chinese (Traditional Han script)) Translated using Weblate (Italian) Translated using Weblate (Polish) Translated using Weblate (Russian) Update translation files MBS-13749: Wrap artist credit links in bdi (#3438) Remove useless API definitions (#3396) Block some more dribbble hardcoded paths MBS-13891: dribbble.com URLs are wrongly blocked MBS-13887: Threads: support @user/post/X thread format MBS-13855: Threads: clean up useless URL parameters Load aliases for artist merge pages Use entity_properties->{aliases} where trivial MBS-13872: Show primary alias in user tags and ratings MBS-13867: Display RG primary alias in artist overview (#3431) MBS-13863: Compare alias with content, not entity name (#3429) Update POT files using the production database Update POT files using the production database MBS-13416: Link to entity pages from LB buttons (#3418) Update translation files Add tests for MBS-13862 Remove duplicate code MBS-13862: Unbreak rel foreign keys for entities of same type Update POT files using the production database Update stylistic to 2.12.0 Update eslint to 9.16.0 Update stylistic to 2.11.0 Update stylistic to 2.10.1 Update eslint to 9.15.0 Update to eslint 9.14.0 Update eslint-plugin-react to 7.37.2 Update to eslint 9.13.0 Update eslint-plugin-react-hooks to 5.0.0 List and disable TS @Stylistic rules List and disable @stylistic/indent-binary-ops Add new @stylistic/curly-newline rule Group all @Stylistic rules Update @stylistic/eslint to 2.9.0 Update rules as per eslint 9.12.0 Update to eslint 9.12.0 Update eslint-plugin-react to 7.37.1 Restore now working no-named-as-default rules Update eslint-plugin-import to 2.31.0 Update hermes-parser to 0.24.0 Update eslint to v8.57.1 Update eslint-plugin-react to 7.36.1 Update eslint-plugin-react to 7.35.2 Update hermes packages Update @babel packages Implement import/no-mutable-exports eslint rule Update eslint-plugin-import to 2.30.0 MBS-12792: Hide ratings by spammer users (#2786) Mitigate flakiness in MBS-2604 test Log error to sentry if dates are dropped MBS-9063: Add tests MBS-9063: Ignore dates in Perl layer when editing rel types without them MBS-9063: Ignore dates in rels editor for rel types without them MBS-13858: Make email Message-Id unique (#3427) Translated using Weblate (Polish) Translated using Weblate (Polish) Translated using Weblate (Polish) Translated using Weblate (Polish) Translated using Weblate (Russian) Translated using Weblate (Polish) MBS-13854: Reword release label edit failure message (#3425) MBS-13170: Handle Bluesky links (#3423) MBS-13795: Update 初音ミク Wiki database validation and cleanup MBS-13850: Accept and cleanup French Ticketmaster MBS-13850: Avoid breaking Peruvian Ticketmaster Don't load no-discid tracklists Use "tbl medium" class in more places MBS-12593: Convert cdtoc/attach_filter_release to React MBS-13795: rename sidebar to original Japanese MBS-13802: Always use "Created (in)" for characters (#3403) MBS-13837: Update JunoDownload favicon (#3419) MBS-13801: Remove limits on tag cloud subqueries (#3400) MBS-13825: Display primary alias for entities on edit display MBS-13780: Show primary alias for series MBS-13780: Show primary alias for release groups MBS-13780: Show primary aliases in merge queue MBS-13780: Show primary alias for releases MBS-13780: Show primary alias for recordings Load artist aliases for instrument artist tab MBS-13780: Show primary alias for places MBS-13780: Show primary alias for genres MBS-13780: Show primary alias for events Split load_aliases from load_related_info and use in more places Use existing $artist_model variable MBS-13780: Show primary alias for labels MBS-13780: Show primary alias for areas MBS-13780: Show primary alias for works MBS-13580: Show primary aliases on artist credits Do not load ACs in set_lengths_to_cdtoc Drop unneeded passedHover Don't try to load artist credits if not supported MBS-13818: Show primary aliases on related entities Add attribute current_language to Server and Context MBS-13571: Show primary aliases on subscription page MBS-13561: Show primary aliases on tag page Do not show primary aliases for instruments Extract alias properties to role Extract and generalize load_aliases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-13802
Description
We changed this for sidebar display for
Createda while ago, but I missed the artist editor, and area should useCreated infor consistency.This keeps the standard end date / end area strings; that section will eventually be hidden for characters with #3402 but for now keeping it as default seems best.
Testing
Manually.